[tcpdump-workers] Should the tcpdump tests be run with TZ=GMT0, or should the AFS printer print time stamps in UTC?

Francois-Xavier Le Bail devel.fx.lebail at orange.fr
Tue Aug 14 03:48:34 EDT 2018


On 12/08/2018 22:57, Denis Ovsienko wrote:
>  ---- On Sun, 12 Aug 2018 20:35:36 +0100 Guy Harris <gharris at sonic.net> wrote ---- 
>  > On Aug 12, 2018, at 7:06 AM, Francois-Xavier Le Bail <devel.fx.lebail at orange.fr> wrote: 
>  >  
>  > > Should we add the "Z" suffix (for UTC) ? 
>  > > strftime(time_buf, sizeof (time_buf), "%Y-%m-%dT%H:%M:%SZ", tm); 
> 
> That's a good point, I used to think the "T" is both mandatory and indicates the zero offset, but having looked up the spec those are actually properties of the (missing) "Z", whereas "T" (in the RFC version) may be replaced with a space.
> 
>  > Should we do so in ts_date_hmsfrac_print() as well, if time_flag isn't LOCAL_TIME?
> 
> Looks like so.

The only uses of "time_flag isn't LOCAL_TIME" of ts_date_hmsfrac_print() function, are the -ttt and
-ttttt cases. Therefore, I don't think the "Z" suffix should be added in these cases.


More information about the tcpdump-workers mailing list