[tcpdump-workers] Speed specific Link-Layer Header Types for USB 2.0

Tomasz Moń desowin at gmail.com
Mon Jun 27 14:21:19 EDT 2022


On Mon, 2022-06-20 at 08:34 -0400, Michael Richardson wrote:
> Tomasz Moń <desowin at gmail.com> wrote:
>     > On Tue, 2022-06-14 at 10:49 -0400, Michael Richardson wrote:
>     >> Tomasz Moń via tcpdump-workers wrote:
>     >>     > I think I have summed up whole discussion in the libpcap commit
>     >>     > message. High-speed and Low-speed are pretty much clear, as these links
>     >>     > never observe other speed packets. Full-speed is the only disputable
>     >>     > one, but I believe the PRE packets are really a corner case that is not
>     >>     > worth per-packet speed encoding. If the user has obsolete setup to
>     >>     > trigger the corner case in the first place, then such user will
>     >>     > definitely know to just capture at the downstream link for low-speed
>     >>     > traffic.
>     >>
>     >> I think that Guy and I thought that you'll be better off with a single
>     >> LINKTYPE with a subtype header, but if you want to go with three, I don't
>     >> object.
> 
>     > I don't see any value (and according to information theory there is no
>     > information) in per packet subtype header that would be set to exactly
>     > the same value for *every single packet* captured on Low- or High-speed
>     > link.
> 
> That's fine with me.
> I will merge the pull request this afternoon.

A week has passed and the pull requests are still pending. Is there
anything left to do on my end?

Best Regards,
Tomasz


More information about the tcpdump-workers mailing list